RFR(M): 8069207 - [TESTBUG] Exception thrown for java.lang.NoSuchMethodError: sun.misc.Unsafe.monitorExit
david.holmes at oracle.com
Mon Jan 19 00:58:08 UTC 2015
On 17/01/2015 4:40 AM, Christian Tornqvist wrote:
> Hi everyone,
> Please review this change adding tests for sun.misc.Unsafe, it's a rewrite
> of some internal tests that were written for another test framework. The
> change includes removing the tests for monitorEnter/Exit.
Without comparing to the existing tests these look okay - pretty basic
API functional checks. But there seem to be a number missing (eg
reallocateMemory, staticFieldOffset, objectFieldOffset, and others) - I
assume the omission of tests for the deprecated methods is deliberate?
One meta-question (as usual) - don't you need to ensure the testlibrary
code is built if you are going to use it?
Some indentation/layout issues:
Looks like spurious tab/indent at line 46.
Ditto line 51 in all files
Indentation issues at: 39, 45 and 48
Indentation wrong for all of main().
Indentation all over the place
> The tests have been verified to work on all our major platforms (using
> Bug (unfortunately not visible):
More information about the hotspot-runtime-dev