RFR 8071962 The SA code needs to be updated to support Symbol lookup from the shared archive
jiangli.zhou at oracle.com
Fri Jan 30 17:46:38 UTC 2015
Thanks for the review.
On Jan 30, 2015, at 3:08 AM, Dmitry Samersoff <dmitry.samersoff at oracle.com> wrote:
> Looks good for me.
> SymbolTable.java 97
> I would prefer to just
> return sharedTable.probe(name, hashValue);
> to avoid unnecessary changes, but it's not a concern - you can leave it
> as is.
Thanks you for the suggestion. Sounds good to me. I’ll make the change and post a new webrev that incorporates everyone’s feedback.
> On 2015-01-30 04:13, Jiangli Zhou wrote:
>> Please review the change for JDK-8071962, "The SA code needs to be updated to support Symbol lookup from the shared archive”.
>> In JDK-8059510, we introduced a compact form of hash table for the symbols in shared archive. The shared symbols are stored separately from the regular symbol table. The VM looks up both tables when searching for existing symbol at runtime. The SA code needs to do the same when looking up symbols.
>> Webrev: http://cr.openjdk.java.net/~jiangli/8067977/webrev.00/
>> Tested on both 32-bit and 64-bit platforms:
>> bin/java sun.jvm.hotspot.tools.DumpJFR <pid>
>> JPRT tests in progress.
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.
More information about the hotspot-runtime-dev