RFR(S): 8132242: LogTouchedMethods (8025692) asserts if TieredCompilation is off.
volker.simonis at gmail.com
Wed Jul 29 08:21:11 UTC 2015
Hi Goetz, Yumin,
the change looks good!
You can go ahead and push it.
On Tue, Jul 28, 2015 at 5:48 PM, Yumin Qi <yumin.qi at oracle.com> wrote:
> Thanks for taking care of this issue. It looks good. I am not a "R"eviewer
> and I think Ioi is not either, we still need a 'R'eviewer to give a pass.
> I can sponsor for the push.
> On 7/28/2015 1:58 AM, Lindenmaier, Goetz wrote:
>> Yumin, could you have a look at this, please? It's trivial.
>> Or could someone else sponsor this?
>> ... I added the bugID I forgot before to the subject.
>> Best regards,
>> -----Original Message-----
>> From: Daniel D. Daugherty [mailto:daniel.daugherty at oracle.com]
>> Sent: Donnerstag, 23. Juli 2015 15:49
>> To: Lindenmaier, Goetz
>> Cc: hotspot-runtime-dev at openjdk.java.net
>> Subject: Re: RFR(S): LogTouchedMethods (8025692) asserts if
>> TieredCompilation is off.
>> Since you did the work on:
>> JDK-8025692 Log what methods are touched at run-time
>> can you help Goetz with this tweak?
>> On 7/23/15 7:30 AM, Lindenmaier, Goetz wrote:
>>> LogTouchedMethods causes the template interpreter to generate profiling
>>> code even
>>> if no compiler is used. If TieredCompilation is off, code containing an
>>> that checks that UseCompiler is set, is reached.
>>> This assertion exists on the sparc and ppc platforms.
>>> Check for LogTouchedMethods in the assertion.
>>> Also added testcase with -XX:-TieredCompilation.
>>> The problem can be reproduced with the new test case on solaris sparc.
>>> Please review this change. I please need a sponsor.
>>> Best regards,
>>> Goetz Lindenmaier
More information about the hotspot-runtime-dev