RFR(M): JDK-8132214: [TESTBUG] Create basic shared strings test for CDS archive
mikhailo.seledtsov at oracle.com
Fri Jul 31 17:05:20 UTC 2015
Thank you for review.
Also, I got some feedback from Christian T. offline, and made the
The changes are minor.
1. Christian: test/runtime/SharedArchiveFile/BasicJarBuilder.java
L39, 70, 91-98 Is the DEBUG variable still useful to have around?
Misha: I have removed the DEBUG statements, think the test has been
tested enough and
these are not needed here anymore.
2. Christian: SharedStrings.java - can you name the .jsa file to
SharedStrings.jsa instead? We had some issues where we suspected the old
.jsa file to be around if the tests were in the same directory, this
would make the naming of them unique.
3. Christian: SharedStrings.java - L53, shouldn’t need the extra
parenthesis around this?
Misha: Done, removed extra parenthesis.
The updated webrev is available at:
On 7/29/2015 4:50 PM, Jiangli Zhou wrote:
> Hi Misha,
> Looks ok. Thanks for adding the test case.
> On Jul 28, 2015, at 10:49 AM, Mikhailo Seledtsov <mikhailo.seledtsov at oracle.com> wrote:
>> Please review an addition of a new test for Shared Strings in CDS archive.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8132214
>> WebRev: http://cr.openjdk.java.net/~mseledtsov/8132214.00/
>> Testing: Ran CDS tests including this newly written test via
>> automated multi-platform testing on standard platforms
>> Thank you,
More information about the hotspot-runtime-dev