RFR (S) 8069111: Investigate NMT detail tracking support for 32bit ARM
chris.plummer at oracle.com
Fri Mar 6 09:07:20 UTC 2015
On 3/5/15 10:22 PM, David Holmes wrote:
> Hi Chris,
> On 4/03/2015 1:33 AM, Chris Plummer wrote:
>> Please help with the review for the changes for JDK-8069111:
>> Webrev: http://cr.openjdk.java.net/~cjplummer/8069111/webrev.06/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8069111
>> Tested with JPRT, including running all NMT tests and vmerror.sh.
>> Many of the changes are in closed code. For the open code, the main
>> changes are to no longer support the
>> PLATFORM_NATIVE_STACK_WALKING_SUPPORTED macro, and no longer allow
>> platforms to include NMT but not include NMT Detail support. The NMT
>> tests have been modified to reflect this. They no longer check if NMT
>> Detail is supported and adjust the testing based on this. The removal of
>> @ignore in some tests is because the cause of these test failures is
>> fixed in the closed changes.
> This all looks good to me.
More information about the hotspot-runtime-dev