RFR (S) 8069111: Investigate NMT detail tracking support for 32bit ARM
coleen.phillimore at oracle.com
Mon Mar 9 17:30:27 UTC 2015
Chris, Thank you! This fix looks really good.
On 3/6/15, 4:07 AM, Chris Plummer wrote:
> On 3/6/15 12:52 AM, Bertrand Delsart wrote:
>> On 03/03/2015 16:33, Chris Plummer wrote:
>>> Please help with the review for the changes for JDK-8069111:
>>> Webrev: http://cr.openjdk.java.net/~cjplummer/8069111/webrev.06/
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8069111
>>> Tested with JPRT, including running all NMT tests and vmerror.sh.
>> Looks good.
>> Thanks for fixing it (particularly the closed part :-)).
>> Bertrand (not a Reviewer).
> Thanks Bertrand!
>>> Many of the changes are in closed code. For the open code, the main
>>> changes are to no longer support the
>>> PLATFORM_NATIVE_STACK_WALKING_SUPPORTED macro, and no longer allow
>>> platforms to include NMT but not include NMT Detail support. The NMT
>>> tests have been modified to reflect this. They no longer check if NMT
>>> Detail is supported and adjust the testing based on this. The
>>> removal of
>>> @ignore in some tests is because the cause of these test failures is
>>> fixed in the closed changes.
More information about the hotspot-runtime-dev