RFR(S): 8074354: tests that intentionally crash the VM can timeout creating a core file

Yumin Qi yumin.qi at oracle.com
Wed Mar 11 16:07:36 UTC 2015


   Thanks for the review.

On 3/11/2015 3:47 AM, Thomas Stüfe wrote:
> Hi Yumin,
> There is also test/runtime/ErrorHandling/SecondaryErrorTest.java - 
> could you please add "-XX:-CreateCoredumpOnCrash" ? Thank you!
> Beyond that, as I wrote in the bug report comments:
> "This is also a problem on Windows - MiniDumpWriteDump() may hang 
> infinitly. And on Windows this is worse than under UNIX because we 
> create the Dump before writing the hs-err file, so if the Dump hangs, 
> we get no error log. I would like to revert the order: create the 
> minidump after writing the error log, the same way Unix does it. We 
> did this in our JVM (SAP) because for us, error logs are more useful 
> than minidumps. "
> So, I would like to see os::abort on Windows call MiniDumpWriteDump(), 
> and thus the mini dump writing moved after the error log writing. This 
> would also make the code way cleaner because the control flow would be 
> the same on all platforms.
> I understand that this may be out of scope for your change, but I 
> would like to know what others think about this.
As in Staffan L's comments, we need to have a discuss and make final 
decision for it --- tradeoff. Personally I prefer a full dump when VM 
crashes on Windows, which is more helpful. I found minidump not very 
helpful in most of the cases.

> Kind regards, Thomas
> On Wed, Mar 11, 2015 at 8:02 AM, Yumin Qi <yumin.qi at oracle.com 
> <mailto:yumin.qi at oracle.com>> wrote:
>     Please review:
>     bug: https://bugs.openjdk.java.net/browse/JDK-8074354
>     webrev: http://cr.openjdk.java.net/~minqi/8074354/webrev01/
>     <http://cr.openjdk.java.net/%7Eminqi/8074354/webrev01/>
>     Summary: Tests timed out when VM crashes and dumping core file
>     which in the test case is not needed. To make core not created,
>     the fix changed CreateMinidumpOnCrash to CreateCoredumpOnCrash,
>     the former is only used on Windows and the latter for all
>     platforms. When VM crashes on non Windows, core file generated as
>     default if OS sets core dump allowed. Default value of
>     CreateCoredumpOnCrash set to 'true' to keep same behavior on non
>     Windows platforms, but changed for Windows --- original is false,
>     not create minidump on Windows. With CreateCoredumpOnCrash turned
>     off, no core file will be generated. CreateMinidumpOnCrash still
>     can be used on commandline but only as alias for the new flag.
>     Tests: JPRT, manual tests setting CreateMinidumpOnCrash on
>     commandline to verify flag change as alias.
>     Thanks
>     Yumin

More information about the hotspot-runtime-dev mailing list