RFR 8160833: ClassesByName2Test.java and RedefineCrossEvent.java failing with jtreg tip
george.triantafillou at oracle.com
Wed Aug 3 14:24:51 UTC 2016
Thanks for your review.
On 8/2/2016 9:49 PM, David Holmes wrote:
> Hi George,
> On 3/08/2016 4:49 AM, George Triantafillou wrote:
>> Please review this small change to fix test failures in two JDI tests:
> There's only one test changed in the webrev ??
RedefineCrossEvent.java simply runs a set of tests, including
ClassesByName2Test.java, with @run driver. So fixing
ClassesByName2Test.java also fixed the failure in RedefineCrossEvent.java.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8160833
>> Open webrev: http://cr.openjdk.java.net/~gtriantafill/8160833/webrev/
>> Thanks to Tim Bell for his assistance. The fix replaces the use of
>> javax.rmi.CORBA.Util with String.format. See this comment
>> for details.
> So the assumption is that String.format will load a bunch of classes
> not already loaded?
Yes, and the test requires that those classes be loaded after
> I assume the problem with javax.rmi.CORBA was module accessibility? Or
> does the Util class no longer exist?
Yes, the problem was module accessibility. I tried to unravel a simple
way to add module access, but was unsuccessful.
> 31 * @modules java.corba
> Presuambly this can be removed?
Yes, good catch. java.corba is no longer required and I've removed it.
New webrev is here:
> However this:
> 56 java.awt.Toolkit tk = java.awt.Toolkit.getDefaultToolkit();
> suggests we need @module java.desktop (which limits this test to
> running on a full JDK).
I don't know, since this was in the initial revision in the repo.
>> Tested locally on Linux with latest version of jtreg.
More information about the hotspot-runtime-dev