RFR: JDK-8163808 fix vtable assertion and logging for older classfiles

Lois Foltan lois.foltan at oracle.com
Fri Aug 12 14:11:57 UTC 2016

Hi Karen,

Looks good.  For my clarification, it doesn't matter what the version of 
the supers are?  The transitive over-ride behavior is only governed by 
the version of the current class whose vtable is being constructed, correct?


On 8/11/2016 5:07 PM, Karen Kinnear wrote:
> Please review:
> https://bugs.openjdk.java.net/browse/JDK-8163808
> http://cr.openjdk.java.net/~acorn/8163808.hs/webrev
> Bug: For classfiles before class file version 51, JVMS did not support transitive over-ride behavior.
> Implementation needed to check this in three places, not just one. Vtable size calculation is only exact
> for later classfile versions.
> Also fixed vtable logging output - since the method name-and-sig printing was changed to also print
> the holder’s class name, we do not need to print the holder’s class name separately - it was printing twice.
> Testing: linux-x64-slowdebug
> rbt hs-nightly-runtime.js
> jck vm,lang, api.java.lang
> small invocation tests
> thanks,
> Karen

More information about the hotspot-runtime-dev mailing list