RFR(XS): 8163973: VM Anonymous classes should not call Class File Load Hooks
lois.foltan at oracle.com
Wed Aug 17 12:35:42 UTC 2016
On 8/16/2016 10:00 PM, Coleen Phillimore wrote:
> On 8/16/16 7:47 AM, Lois Foltan wrote:
>> Hi Rachel,
>> I think this looks good.
>> You might consider adding a nested anonymous class test for this. I
>> believe Harold has developed one for JDK-8030221. I think it would
>> be good to make sure that the host_klass parameter is indeed NULL for
>> a nested anonymous class and that the VM does not go forward into the
>> CFLH code in that scenario.
> Shouldn't the host_class be non NULL for a nested anonymous class too?
Yes it should be, it would just be nice to have a test that tests this.
>> On 8/15/2016 4:48 PM, Rachel Protacio wrote:
>>> Please review this change, which makes sure class file load hooks
>>> are not called for VM anonymous classes. See
>>> for justification.
>>> Passes JPRT and RBT.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8163973
>>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8163973.00/
>>> Thank you!
More information about the hotspot-runtime-dev