PING! Re: RFR(XS): JDK-8160923: sun/tools/jps/TestJpsJar.java fails due to ClassNotFoundException: jdk.testlibrary.ProcessTools
dmitry.samersoff at oracle.com
Tue Aug 23 19:02:15 UTC 2016
Thank you for review.
Hmm. It looks like changes below solves the problem.
- * @build jdk.testlibrary.* JpsHelper JpsBase
+ * @build JpsHelper JpsBase
I'm running rbt job to verify it.
On 2016-08-23 16:10, Ioi Lam wrote:
> Hi Dmitry,
> Why are you adding /test/lib:
> - * @library /lib/testlibrary
> + * @library /lib/testlibrary /test/lib
> The only class used by jdk/test/sun/tools/jps/*.java in /test/lib is here:
> TestJpsSanity.java:import jdk.test.lib.apps.LingeredApp;
> But TestJpsSanity.java is not use by this test -- I ran the test with
> your patch in a clean jtreg directory and the test passed, but I don't
> see TestJpsSanity.class, or any jdk.test.lib.* class.
> So I don't think you need to add /test/lib.
> - Ioi
> On 8/23/16 5:34 AM, Dmitry Samersoff wrote:
>> On 2016-08-17 10:51, Dmitry Samersoff wrote:
>>> Please review the changes:
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
More information about the hotspot-runtime-dev