RFR(S): 8164738: Convert AltHashing_test to GTest

David Holmes david.holmes at oracle.com
Fri Aug 26 03:38:00 UTC 2016

On 25/08/2016 1:47 AM, Kirill Zhaldybin wrote:
> Dear all,
> Could you please review this fix for 8164738?

Seems okay.

> To convert the test I added new friend class to AltHashing class so we
> could access private member function static juint murmur3_32(const int*
> data, int len). There are also few formating fixes.

Any reason all the murmur functions shouldn't be public? I'm not a fan 
of friends. No big deal either way.


> WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8164738/webrev.00/
> CR: https://bugs.openjdk.java.net/browse/JDK-8164738
> Regards, Kirill

More information about the hotspot-runtime-dev mailing list