RFR: 8168850: Mark module entries that have been specified by --patch-module

David Holmes david.holmes at oracle.com
Fri Dec 2 01:44:11 UTC 2016

Hi Rachel,

On 2/12/2016 7:18 AM, Rachel Protacio wrote:
> Hi,
> Please review this fix, which adds a boolean to ModuleEntry to specify
> whether the module has been patched using the command line
> --patch-module. This is needed for CDS to know whether to load a class
> from the shared archive. Their tests for those changes will encompass my
> change here. I verified that it worked properly through the logging
> messages, which can be triggered with
>     -Xlog:modules+patch=trace
> Passes JPRT.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8168850
> Open webrev: http://cr.openjdk.java.net/~rprotacio/8168850.00/

Looks okay.

My only query is with the change in the initialization order for 
create_javabase. Does JPRT testing sufficiently exercise this?


> Thank you!
> Rachel

More information about the hotspot-runtime-dev mailing list