RFR(XS): JDK-8171318 - serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java fails latest Jigsaw integration

David Holmes david.holmes at oracle.com
Tue Dec 20 04:13:22 UTC 2016

Hi George,

On 20/12/2016 1:30 AM, George Triantafillou wrote:
> Please review this small change to fix test failures in
> JMapHProfLargeHeapTest.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8171318
> Open webrev: http://cr.openjdk.java.net/~gtriantafill/8171318/webrev/
> <http://cr.openjdk.java.net/%7Egtriantafill/8171318/webrev/>

Why is this webrev based against jdk9/jdk9 instead of jdk9/hs?

> JMapHProfLargeHeapTest.java: added add-opens to ProcessBuilder, added
> input check for largeHeapScanner.

I can't make the existing test fail. I would have thought that 
--add-exports subsumed the need to do --add-opens? I've been trying to 
find any doc to clarify that. But it seems to me that this test as-is 
doesn't seem to fail since the most recent Jigsaw refresh.


> Tested locally on Linux.
> Thanks.
> -George

More information about the hotspot-runtime-dev mailing list