RFR(xs): 8149096: Remove unused code in methodComparator

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Mon Feb 8 19:22:27 UTC 2016

Hi Thomas,

The fix looks good.
The following variable and all its uses are dead too as it never gets 
'true' value.
But it is up to you to fix it or not.

I can sponsor and push the fix.

Thank you for taking care about this.

On 2/8/16 06:24, Thomas Stüfe wrote:
> Hi all,
> please review and sponsor this little change. It gets rid of two 
> unused methods in methodComparator(cpp/hpp).
> We stumbled over this because of warings about unchecked realloc() 
> return values; but instead of fixing the code, we may just remove the 
> offending methods, because they are not used anywhere.
> See also mail thread here: 
> http://openjdk.5641.n7.nabble.com/Unused-code-in-prims-methodComparator-td254425.html.
> bug: https://bugs.openjdk.java.net/browse/JDK-8149096
> webrev: 
> http://cr.openjdk.java.net/~stuefe/webrevs/8149096-remove-unused-code-methodComparator/webrev.00/webrev/ 
> <http://cr.openjdk.java.net/%7Estuefe/webrevs/8149096-remove-unused-code-methodComparator/webrev.00/webrev/> 
> Kind Regards, Thomas

More information about the hotspot-runtime-dev mailing list