RFR(xs): 8149096: Remove unused code in methodComparator

David Holmes david.holmes at oracle.com
Tue Feb 9 04:20:14 UTC 2016

On 9/02/2016 5:22 AM, serguei.spitsyn at oracle.com wrote:
> Hi Thomas,
> The fix looks good.
> The following variable and all its uses are dead too as it never gets
> 'true' value.

I think _switchable_test is the variable Serguei was referring to. The 
whole notion of switchability is "dead" now so all code that relates to 
_switchable_test being true is also dead. Also any comment use of 

> But it is up to you to fix it or not.

I'd like to see it all cleaned up please. :)


> I can sponsor and push the fix.
> Thank you for taking care about this.
> Serguei
> On 2/8/16 06:24, Thomas Stüfe wrote:
>> Hi all,
>> please review and sponsor this little change. It gets rid of two
>> unused methods in methodComparator(cpp/hpp).
>> We stumbled over this because of warings about unchecked realloc()
>> return values; but instead of fixing the code, we may just remove the
>> offending methods, because they are not used anywhere.
>> See also mail thread here:
>> http://openjdk.5641.n7.nabble.com/Unused-code-in-prims-methodComparator-td254425.html.
>> bug: https://bugs.openjdk.java.net/browse/JDK-8149096
>> webrev:
>> http://cr.openjdk.java.net/~stuefe/webrevs/8149096-remove-unused-code-methodComparator/webrev.00/webrev/
>> <http://cr.openjdk.java.net/%7Estuefe/webrevs/8149096-remove-unused-code-methodComparator/webrev.00/webrev/>
>> Kind Regards, Thomas

More information about the hotspot-runtime-dev mailing list