RFR: 8148987: [Linux] Allow building on older systems without CPU_ALLOC support
david.holmes at oracle.com
Wed Feb 10 21:22:48 UTC 2016
Thanks for the Review Dan!
On 11/02/2016 1:02 AM, Daniel D. Daugherty wrote:
> On 2/5/16 12:50 AM, David Holmes wrote:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8148987
>> webrev: http://cr.openjdk.java.net/~dholmes/8148987/webrev/
> No comments on the code.
> I like the fact that you minimized the #ifdef's as much as possible.
> I also like the fact that you handle CPU_ALLOC and CPU_COUNT separately;
> in the world of variant Linux distros, I think handling more possible
> variants (with in reason) is good.
Okay then I will stick with this version - sorry Dmitry :)
>> This is a tentative RFR as I'm not yet convinced we should support
>> building on these older platforms in JDK 9. Opinions welcome on that
> I got the impression that Thomas Stufe's sighting with their
> Linux PowerPC build was on JDK9 code base. Now that I reread
> that part of the thread, there's nothing stating that clearly,
> but I think you should make this chnage in JDK9.
Yes Thomas was building 9 on a very old system.
Okay I will proceed with this.
> Thumbs up!
>> The older systems do not have dynamic cpu set support (CPU_ALLOC) nor
>> do they have the CPU_COUNT utility macro.
More information about the hotspot-runtime-dev