RFR(XS): 8150079: MSVC prior to VS 2013 doesn't know the 'va_copy' macro

Volker Simonis volker.simonis at gmail.com
Wed Feb 17 18:54:27 UTC 2016


can I please have a review and a sponsor for the following small
change which fixes a build issue with VS2010:


Change "8146793: logStream::write re-formats string" introduced an
unconditional usage of the 'va_copy' macro which is not known to MSVC
versions prior to VS2013.

The HotSpot code base already uses the 'va_copy' macro in jni.cpp with
a guard against it being undefined.

This change will move the conditional guard and redefinition of
'va_copy' from jni.cpp to globalDefinitions_visCPP.hpp to make it
available in all HotSpot source files.

Thank you and best regards,

More information about the hotspot-runtime-dev mailing list