JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9
rachel.protacio at oracle.com
Wed Feb 17 22:02:12 UTC 2016
Thanks for the review, Harold!
On 2/17/2016 4:35 PM, harold seigel wrote:
> Hi Rachel,
> The changes look good!
> Thanks, Harold
> On 2/17/2016 4:21 PM, Rachel Protacio wrote:
>> Hello, everyone,
>> We are moving forward with "JNI_VERSION_9". If it later turns out
>> that it should be "9_0", we will file a separate bug, but the plain 9
>> is most likely. There is currently a compatibility request in the
>> approval process.
>> Here is the updated code, which builds properly and still prints the
>> correct version from my own private test.
>> hotspot repo webrev:
>> jdk repo webrev: http://cr.openjdk.java.net/~rprotacio/JNI_jdk.01/
>> Thank you,
>> On 1/27/2016 6:02 PM, Rachel Protacio wrote:
>>> Small but important change for review: updating the JNI_VERSION and
>>> in so doing, changing the format from JNI_VERSION_1_x to
>>> JNI_VERSION_x_y (see code/bug for details).
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8145098
>>> hotspot repo webrev: http://cr.openjdk.java.net/~rprotacio/JNI_hotspot/
>>> jdk repo webrev: http://cr.openjdk.java.net/~rprotacio/JNI_jdk/
>>> I grep'ed through the code to find references to the current JNI
>>> version and believe I have caught all the ones that needed changing,
>>> plus the fact that all these tests pass:
>>> * local hotspot jtreg tests
>>> * my own sample JNI test to print and visually inspect the version
>>> (essentially what is performed by the updated
>>> hotspot/test/native_sanity/JniVersion.java test)
>>> * jck vm tests
>>> * local rbt colcated and noncolocated tests, especially for the
>>> purpose of hitting tonga/src/nsk/share/jvmti tests where
>>> JNI_GetVersion() is used
>>> Thank you,
More information about the hotspot-runtime-dev