RFR(XS): 8150079: MSVC prior to VS 2013 doesn't know the 'va_copy' macro

David Holmes david.holmes at oracle.com
Thu Feb 18 03:14:34 UTC 2016

Hi Volker,

On 18/02/2016 4:54 AM, Volker Simonis wrote:
> Hi,
> can I please have a review and a sponsor for the following small
> change which fixes a build issue with VS2010:
> http://cr.openjdk.java.net/~simonis/webrevs/2016/8150079/
> https://bugs.openjdk.java.net/browse/JDK-8150079
> Change "8146793: logStream::write re-formats string" introduced an
> unconditional usage of the 'va_copy' macro which is not known to MSVC
> versions prior to VS2013.
> The HotSpot code base already uses the 'va_copy' macro in jni.cpp with
> a guard against it being undefined.
> This change will move the conditional guard and redefinition of
> 'va_copy' from jni.cpp to globalDefinitions_visCPP.hpp to make it
> available in all HotSpot source files.

This looks fine. I hereby Review it and sponsor it. I will consider this 
a trivial change and push it forthwith.


> Thank you and best regards,
> Volker

More information about the hotspot-runtime-dev mailing list