RFR[8u-dev]: 8139040: Fix initializations before ShouldNotReachHere() etc. and enable -Wuninitialized on linux.

David Holmes david.holmes at oracle.com
Tue Feb 23 09:36:08 UTC 2016

Hi Cheleswer,

On 23/02/2016 7:06 PM, Cheleswer Sahu wrote:
> Could somebody please review the below backport changes.
> Hi,
> Please review the code changes for backport "https://bugs.openjdk.java.net/browse/JDK-8139040".
> JBS link: https://bugs.openjdk.java.net/browse/JDK-8139040
> JDK9 changeset:
> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/825cee2cd7a6
> JDK9 review thread:
> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-October/016005.html
> JDK8u webrev: http://cr.openjdk.java.net/~csahu/8139040/

Looks ok.

> List of files not included in this backport:
>      src/share/vm/classfile/compactHashtable.cpp
>      src/share/vm/opto/compile.hpp
>      src/share/vm/opto/superword.cpp
>      src/share/vm/runtime/arguments.cpp
>      Reason: Above file are either not available in JDK8u or changes are not applicable.


> make/linux/makefiles/gcc.make
>     Reason: This file contain changes related  "-Wuninitialized" flag which is available since gcc4.8 . JDK8u is supporting lower version of gcc, hence not included this fix.

You can add a check for gcc >= 4.8 when enabling this flag. Although our 
official compilers are quite old for 8u there may be other community 
members who use later versions.


> Regards,
> Cheleswer

More information about the hotspot-runtime-dev mailing list