RFR: 8149743: JVM crash after debugger hotswap with lambdas
andreas.eriksson at oracle.com
Tue Feb 23 15:34:18 UTC 2016
On 2016-02-23 15:11, Daniel D. Daugherty wrote:
> On 2/18/16 9:11 AM, Andreas Eriksson wrote:
>> Please review this fix for JDK-8149743: JVM crash after debugger
>> hotswap with lambdas
>> Webrev: http://cr.openjdk.java.net/~aeriksso/8149743/webrev.00/
> No comments other than please update the copyright before you push.
> L76: debuggeeFailIfPresent "Internal exception:"
> Is the failure mode for this bug always a crash? If so, then
> the above check should work as long as we don't change the
> "Internal exception:" part of the output. If we do that then
> we'll have to update a number of tests... :-)
Yes, it's always a crash/assert. The runit call checks for some common
hs_err output as well, so even if that specific output changes it should
> Thumbs up.
Thanks for the review.
>> When redefining a class to add or delete methods an array that's
>> tracking method ordering is not updated correctly.
>> This change swaps the method ordering array between the old class
>> being redefined and the scratch class it is being redefined into at
>> the same point where we swap the methods and constant pool between them.
More information about the hotspot-runtime-dev