RFR: 8146879: Truncate new UL log files

Bengt Rutisson bengt.rutisson at oracle.com
Fri Jan 15 09:27:44 UTC 2016

On 2016-01-14 23:43, Kim Barrett wrote:
> On Jan 14, 2016, at 10:00 AM, Marcus Larsson <marcus.larsson at oracle.com> wrote:
>> Hi,
>> Please review the following patch to make sure UL truncates existing log files before writing to them. Since files are opened in append mode, truncation isn't done automatically, so instead the patch adds an attempt to remove the log file before opening it.
>> Webrev:
>> http://cr.openjdk.java.net/~mlarsson/8146879/webrev.00/
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8146879
>> Testing:
>> Included test through JPRT
>> Thanks,
>> Marcus
> Deleting possibly critical data seems like a good way to generate a mob of angry users.

The GC log has always been overwritten on a restart. The propsed change 
to the UL file handling makes the log files work similar to how they 
used to work. So, I think we will get less problems with users after 
this change than before it.


More information about the hotspot-runtime-dev mailing list