RFR: 8147500: The HashtableTextDump::get_num() should check for integer overflow

David Holmes david.holmes at oracle.com
Fri Jan 22 04:37:09 UTC 2016

Hi Jiangli,

> Please review the following improvements to HashtableTextDump::get_num() and HashtableTextDump::corrupted_if() described in JDK-8147500 <https://bugs.openjdk.java.net/browse/JDK-8147500>.
>  - The HashtableTextDump::get_num() is use to parse an integer value from the input file. It should check for integer overflow and report error without continuing.
>  - The HashtableTextDump::corrupted_if() should take an additional argument so caller can pass a meaningful error message.
> Webrev: http://cr.openjdk.java.net/~jiangli/8147500/webrev.00/

As improvements on the existing code this seems fine.


More information about the hotspot-runtime-dev mailing list