RFR(XS): 8146187: Print develop and nonproduct flags by -XX:+PrintFlags* options in debug build

Gerard Ziemski gerard.ziemski at oracle.com
Thu Jan 28 17:49:51 UTC 2016

Resending referencing the correct issue:

hi Dmitry,


No comments except that this was easy ;-) And thank you for getting rid of extraneous “printRanges” check. 


So we are not going to test the debug (non-product) flags at all, even on the debug build? (requires too much time?)

> On Jan 28, 2016, at 5:07 AM, Dmitry Dmitriev <dmitry.dmitriev at oracle.com> wrote:
> Hello,
> Can I get review for that small patch please?
> Thanks,
> Dmitry
> On 19.01.2016 14:32, Dmitry Dmitriev wrote:
>> Hello,
>> Please review small fix for printing flags functionality. This fix return ability to print develop and not product flags in debug VM by -XX:+PrintFlags* options.
>> Few comments:
>> 1) "if (printRanges) {" on line 407 in globals.cpp was deleted, because it located in else branch of "if (!printRanges) {" and therefore always true.
>> 2) TestOptionsWithRanges.java was corrected to not pick develop and not product flags.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8146187
>> webrev.00: http://cr.openjdk.java.net/~ddmitriev/8146187/webrev.00/ <http://cr.openjdk.java.net/%7Eddmitriev/8146187/webrev.00/>
>> Testing: JPRT, hotspot_all, vm.quick
>> Thanks,
>> Dmitry

More information about the hotspot-runtime-dev mailing list