RFR(S): 8168493: Convert TestBitMap_test to GTest
kim.barrett at oracle.com
Wed Nov 2 01:39:28 UTC 2016
> On Nov 1, 2016, at 9:45 AM, Kirill Zhaldybin <kirill.zhaldybin at oracle.com> wrote:
> Dear all,
> Could you please review this fix for 8168493?
> WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8168493/webrev.00/
> CR: https://bugs.openjdk.java.net/browse/JDK-8168493
> 1. Usual gtest conversion - asserts, file location etc
> 2. Simplified the test a bit - deleted unused template parameter, refactoring
> 3. Deleted friend class from BitMap class since we actually do not need it
> Thank you.
> Regards, Kirill
Conversion looks good.
We ought to have more extensive tests of this class, but that’s out of scope for this conversion.
I have a test for the search and iteration operations that is waiting on JDK 10: JDK-8169039.
More information about the hotspot-runtime-dev