Request Review: JDK-6479237 (cl) Add support for classloader names
mandy.chung at oracle.com
Thu Nov 3 00:53:40 UTC 2016
> On Nov 2, 2016, at 5:48 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
> On 11/2/16 8:47 PM, Mandy Chung wrote:
>>> On Nov 2, 2016, at 5:40 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
>>> I missed some of the iterations of this. To avoid making a large change larger, I think you should keep the original names of ToStackTraceElement and GetStackTraceElements.
>> There is no change to the name of these JVM entry points.
>> This patch changes the private native methods in the library. Is that what concerns you?
> Yes, the names of the library methods don't match the JVM names anymore. I think changing the names are unnecessary and makes it not obvious the mapping.
Is there such convention? I wasn’t aware of that. In addition, it would be impractical to synchronize the native methods to match JVM function names.
More information about the hotspot-runtime-dev