RFR(XS) 8170431: non-ASCII characters in source code comments (jimage.hpp)

Naoto Sato naoto.sato at oracle.com
Tue Nov 29 17:21:20 UTC 2016

Looks fine, David.


On 11/28/16 9:42 PM, David Buck wrote:
> Hi!
> Please have a look at this small yet urgent fix to comments in a header
> file.
> bug report: https://bugs.openjdk.java.net/browse/JDK-8170431
> webrev: http://cr.openjdk.java.net/~dbuck/jdk8170431_0/
> These changes are exactly the same as the changes made by Naoto to the
> class library's copy of jimage.hpp:
> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/cfa705d1f4e2
> This is actually an important fix because VS will choke on this file
> under certain Windows locales (Chinese and Japanese have been reported
> so far). So the build is broken for many users without this fix.
> Cheers,
> -Buck

More information about the hotspot-runtime-dev mailing list