RFR(S) 8149607: [Verifier] Do not verify pop, pop2, swap, dup* against top

Karen Kinnear karen.kinnear at oracle.com
Wed Sep 7 22:22:00 UTC 2016


Code change was beautifully clean!

Thank you for all the tests.

Looks good.


> On Aug 31, 2016, at 2:21 PM, harold seigel <harold.seigel at oracle.com> wrote:
> Hi,
> Please review this verifier fix to disallow popping a single operand of type 'top' from the stack in case it's the upper half of a long or double operand.  See the Java Virtual Machine Spec <http://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-> for information about type 'top' operands.
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8149607
> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8149607/
> The fix was tested with the JCK Lang and VM tests, the hotpot, and java/lang, java/util and other JTreg tests, and the NSK colocated and non-colocated quick tests.
> Thanks, Harold

More information about the hotspot-runtime-dev mailing list