RFR(S): 8160064: StackWalker implementation added logging option without using UL
coleen.phillimore at oracle.com
Wed Sep 28 18:16:50 UTC 2016
One simple change that I don't need to see that might have gotten lost
in my other review:
+ ResourceMark rm;
+ ResourceMark rm(THREAD);
So that the code doesn't expand to call Thread::current().
It's in two places.
I really like the simplified test! This looks good.
On 9/28/16 12:40 PM, Rachel Protacio wrote:
> Updated webrev: http://cr.openjdk.java.net/~rprotacio/8160064.01/
> Includes simplified test, log_is_enabled checks, and logging on debug
> On 9/27/2016 3:47 PM, Rachel Protacio wrote:
>> Please review this small fix correcting the StackWalker print output
>> mechanism by moving it to Unified Logging. Includes a new jtreg test,
>> and passes JPRT.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8160064
>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8160064/
>> Thank you!
More information about the hotspot-runtime-dev