RFR(S) 8178118: Arguments::create_numbered_property allocates wrong buffer in case count > 99

Daniel D. Daugherty daniel.daugherty at oracle.com
Thu Apr 6 01:14:41 UTC 2017

On 4/5/17 3:24 PM, Ekaterina Pavlova wrote:
> Hi everyone,
> Please review this change that fixes memory allocation in Arguments::create_numbered_property.
> Also added error messages so java prints some hints except just exiting with "Error: Could not create the Java Virtual Machine"
> (tested by adding error in 'prop_len' calculation).
> This is perhaps zero day bug but it was recently discovered when testing with multiple '-add-exports' options.
>     bug: https://bugs.openjdk.java.net/browse/JDK-8178118
> webrev:  http://cr.openjdk.java.net/~iignatyev/epavlova/8178118/

     L2590:    const unsigned int props_count_limit = 1000;
     L2591:    const int props_count_limit_log10 = 3;
     L2592:    const int extra_symbols_count = 3; // includes '.', '=', '\0'
         The indent for these three line is 3 spaces; should be 2 spaces.

Don't need to see another webrev if you fix the indent.
Thumbs up!


> Tested by running jprt.
> -katya

More information about the hotspot-runtime-dev mailing list