RFR 8150388: Remove SPARC 32-bit support

Kim Barrett kim.barrett at oracle.com
Sat Apr 15 18:21:04 UTC 2017

> On Apr 15, 2017, at 4:27 AM, Kim Barrett <kim.barrett at oracle.com> wrote:
> src/cpu/sparc/vm/globalDefinitions_sparc.hpp
>  43 #elif defined(COMPILER1)
>  44   // pure C1, 32-bit, small machine
>  45   #define DEFAULT_CACHE_LINE_SIZE 16
> Comment suggests this is a configuration we don't use with 64bit.

And if we did, the resulting value seems suspect. But someone with
more knowledge than I have should figure out what should really be
done here. It's not the kind of mostly mechanical change that this RFE
is about.

> src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.hpp 
> 166 #if defined(COMPILER2) || defined(_LP64)
> and
> 228 #endif // _LP64 || COMPILER2
> I think the _LP64 parts of these can be removed.

That was wrong of me. As written, the #if/#endif can be just removed.
It would be a change to remove just the _LP64 part.

OTOH, the comment at the head of the protected section suggests this
is mostly for sparc-v8 support, and I believe we don't support that
anymore, so further cleanup perhaps to be had here, in some different
RFE.  (Assuming I'm remembering correctly that we no longer support
v8, is there an existing RFE for that cleanup?)

> src/os_cpu/solaris_sparc/vm/prefetch_solaris_sparc.inline.hpp
>  30 #if defined(COMPILER2) || defined(_LP64)
> and
>  58 #endif // defined(COMPILER2) || defined(_LP64)
> I think the _LP64 parts of these can be removed.

As with the one above, this comment is similarly wrong.

More information about the hotspot-runtime-dev mailing list