RFR(xxs, jdk10): 8171508: os::jvm_path -XXaltjvm processing error after 8066474
david.holmes at oracle.com
Wed Apr 26 07:39:10 UTC 2017
On 26/04/2017 5:10 PM, Thomas Stüfe wrote:
> Hi all,
> may I please have a review for this tiny fix. 8066474 removed the <arch>
> directory from the images and since then -XXaltjvm was slightly broken.
> When handling XXaltjvm, os::jvm_path() examines the path of the libjvm.so
> to check if it is part of what it considers a standard JDK by traversing a
> number of slashes up the path and looking for "/jre/lib". That number of
> slashes was off since 8066474.
On BSD we never had the <arch> directory so that seems to have always
been broken - despite the updated comment!
> Bug: https://bugs.openjdk.java.net/browse/JDK-8171508
> Note that this only affects cases where the alternate libjvm.so is part of
> a full jdk, so it does not affect the gtestLauncher.
Changes look good.
I wonder whether we can easily write a simple sanity test for this? eg
by pointing altjvm to the actual JDK path?
> Thanks & Regards, Thomas
More information about the hotspot-runtime-dev