RFR 8174092: Remove array-related access checks from Reflection::verify_class_access()
harold.seigel at oracle.com
Thu Feb 9 14:59:38 UTC 2017
On 2/9/2017 9:58 AM, Karen Kinnear wrote:
> Looks good. I like the way you chose to fix this.
>> On Feb 9, 2017, at 9:49 AM, harold seigel <harold.seigel at oracle.com> wrote:
>> Please review this JDK-10 fix for bug JDK-8174092. The new_class parameters passed to Reflection::verify_class_access() and verify_class_access_msg() are always going to be of type InstanceKlass*. So, this fix changes its type to InstanceKlass* and removes code that checks for other Klass* types.
>> Note that the InstanceKlass::cast(Klass*) function used by this fix will assert if the Klass* is not an InstanceKlass*. So, no additional asserts that a Klass* is an InstanceKlass* are needed.
>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8174092/webrev/index.html
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8174092
>> The fix was tested with the JCK Lang and vm tests, the JTreg hotspot, java/io, java/lang, and java/util tests, the nsk colocated and the non-colocated tests, and with JPRT.
>> Thanks, Harold
More information about the hotspot-runtime-dev