RFR(XS) 8184991: NMT detail diff should take memory type into account

Aleksey Shipilev shade at redhat.com
Thu Jul 20 17:25:31 UTC 2017

On 07/20/2017 07:13 PM, Zhengyu Gu wrote:
> After JDK-8139673, there can be multiple malloc site records for a allocation
> path, but with different memory types.
> When diffing the malloc sites, the comparison should be made to the sites, not
> only with the same allocation path, but also with the same memory type.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8184991
> Webrev: http://cr.openjdk.java.net/~zgu/8184991/webrev.00/index.html

 *)  320   // Report type only it is valid

 "Report type only *if* it is valid"?

Otherwise looks good.


More information about the hotspot-runtime-dev mailing list