RFR: 8175318: Performance issue regarding local JNI references

Aleksey Shipilev shade at redhat.com
Fri Jul 21 06:52:24 UTC 2017

On 07/20/2017 11:09 PM, Kim Barrett wrote:
> I decided not to bother with is_clear() right now.  There would just be the couple of
> uses in the vicinity of this change, plus a !is_clear() in print_statistics.  If anything,
> I’d be inclined to remove the unused clear() function. I looked at the places where
> we zero _top, and I don’t think any of them are particularly improved by calling clear().

IMO, clear() and is_clear() capture the intent of _top manipulation better, thus
improving long-term maintainability. Our descendants would not have to read all
the uses of _top to verify "_top = 0" indeed serves as clear(). But, your call.


More information about the hotspot-runtime-dev mailing list