URGENT RFR (S): fix for Test8004741.java crashes with SIGSEGV in JDK10-hs nightly (8185273)
vladimir.kozlov at oracle.com
Mon Jul 31 18:39:35 UTC 2017
Can you put new code which used for assert check under #ifdef ASSERT to avoid side effects in product code?
> On Jul 31, 2017, at 10:26 AM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> Thanks for the re-review! (and for the reworded comment...)
>> On 7/31/17 11:24 AM, Aleksey Shipilev wrote:
>>> On 07/31/2017 07:07 PM, Daniel D. Daugherty wrote:
>>> Latest webrev: http://cr.openjdk.java.net/~dcubed/8185273-webrev/1/
>>> Only src/share/vm/runtime/thread.cpp is changed relative to round 0:
>>> - Revised the comment in Threads::parallel_java_threads_do.
>>> - Added the assert to Threads::assert_all_threads_claimed().
>>> Comments, questions and feedback are welcome.
>> Looks good!
>> P.S. Roman: I'm going to cherry-pick that to Shenandoah after this lands to jdk10/hs.
More information about the hotspot-runtime-dev