RFR: JDK-8180322 Move JNI spec to specs directory

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Jun 2 09:50:18 UTC 2017

> 2 juni 2017 kl. 03:44 skrev David Holmes <david.holmes at oracle.com>:
> Hi Magnus,
> Serviceability owns the jvmti.xml file, so cc'd.
> The changes to externalink seem okay (I assume the GetEnv -> getenv change is not significant?).

It matches the changes in the source document. 

> The patch file seems to contain a bazillion whitespace changes so you might want to check what is going on there.

Those were trailing whitespaces. Unfortunately, jcheck only enforces the "no trailing whitespaces" rule for certain file types (or technically extensions), and .xml is not one of them (and neither is .gmk :-(). I have instructed my editor to remove trailing whitespaces always, and sometimes this means a patch gets lots of whitespace cleanup. 


> Thanks,
> David
>> On 1/06/2017 10:46 PM, Magnus Ihse Bursie wrote:
>> The JNI spec will move to a new place in the "specs" directory in the docs image, and links to it needs to be updated.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180322
>> WebRev: http://cr.openjdk.java.net/~ihse/JDK-8180322-move-jni-spec/webrev.01
>> This is a noreg-docs fix and will be pushed to jdk9.
>> /Magnus

More information about the hotspot-runtime-dev mailing list