RFR 8026985: Rewrite SystemDictionary::classes_do and Dictionary::classes_do to use KlassClosure

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Fri Mar 10 09:07:44 UTC 2017

Hi Coleen,

Nice cleanup!
It looks good to me.
I'm also interested in reply to David's questions.

One minor comment:


- SystemDictionary::always_strong_classes_do(&class_dumper);
+ ClassLoaderData::the_null_class_loader_data()->classes_do(&class_dumper);
+ //SystemDictionary::always_strong_classes_do(&class_dumper); It is 
probably better to remove the commented line.


On 3/8/17 08:24, coleen.phillimore at oracle.com wrote:
> Summary: Clean up and examine uses of classes_do for the SystemDictionary
> See bug comments for more details.  I wanted to clean this up while 
> examining the idea of having system dictionary information added per 
> ClassLoaderData, rather than a global table.
> open webrev at http://cr.openjdk.java.net/~coleenp/8026985.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8026985
> Tested with java.lang.instrument, sun.com.jdi, tonga colocated 
> (closed) tests, and JPRT, because of difference in which classes_do is 
> called for heap dumping.
> Note, will update copyrights on commit.
> Thanks,
> Coleen

More information about the hotspot-runtime-dev mailing list