RFR 8176471: [TESTBUG] runtime/modules/IgnoreModulePropertiesTest.java fails with OpenJDK: java.lang.RuntimeException: 'java version ' missing from stdout/stderr
harold.seigel at oracle.com
Tue Mar 14 13:34:02 UTC 2017
Thanks for looking at this change.
I thought about removing the string checks and just relying on the calls
to output.shouldHaveExitValue(0) to indicate success. But ultimately
decided to keep the string checks. Perhaps they check that 'java
-version' produced actual output?
On 3/13/2017 8:37 PM, David Holmes wrote:
> Hi Harold,
> On 14/03/2017 5:18 AM, harold seigel wrote:
>> Please review these fixes for two tests that incorrectly parse the
>> output from 'java -version' commands for the open jdk build.
> I agree these changes will "fix" the tests when run on OpenJDK build.
> However I don't see how checking for these strings is actually testing
> anything relevant to the test being executed.
>> Open Webrevs:
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8176471
>> The fixed tests were tested on open fastdebug and product builds, and on
>> a fastdebug closed build.
>> Thanks, Harold
More information about the hotspot-runtime-dev