RFR JDK-8175288: [TESTBUG] sun/tools/jcmd/TestJcmdDefaults.java failed to parse output of other java process
harold.seigel at oracle.com
Fri Mar 17 12:32:39 UTC 2017
Thanks for the review!
On 3/17/2017 8:25 AM, Christian Tornqvist wrote:
> Hi Harold,
> This looks good, thanks for fixing this.
>> On Mar 16, 2017, at 4:06 PM, harold seigel <harold.seigel at oracle.com> wrote:
>> Please review this JDK-10 fix for test sun/tools/jcmd/TestJcmdDefaults.java. The test gets a list of Java processes and tries to match them to a regular expression. But the match fails if the name of one of the Java processes contains a line terminator.
>> The fix adds "(?s)" to the regular expression used by the test. The "(?s)" enables dotall mode, meaning the "." in the test's regular expression accepts any characters including line terminators.
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8175288/webrev/
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8175288
>> The change was regression tested on Linux, macOS X, Solaris, and Windows using RDB. The modified regular expression was tested using a small Java program that was fed command lines similar to the one that caused the test to fail.
>> Thanks, Harold
More information about the hotspot-runtime-dev