RFR(S): 8181592: [TESTBUG] Docker test utils and docker jdk basic test

Leonid Mesnik leonid.mesnik at oracle.com
Tue Sep 26 18:19:12 UTC 2017


http://cr.openjdk.java.net/~mseledtsov/8181592.00/test/hotspot/jtreg/runtime/containers/docker/DockerBasicTest.java.html <http://cr.openjdk.java.net/~mseledtsov/8181592.00/test/hotspot/jtreg/runtime/containers/docker/DockerBasicTest.java.html>
Copyright is incorrect, need to updated it for GPL.

The Hotspot is Oracle VM name only so test might fail for OpenJDK. I think you need to fix this check.

The requires checks only that test is executed only on the 64-bit linux. Does it make a sense to introduce more docker-specific check?

http://cr.openjdk.java.net/~mseledtsov/8181592.00/test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest.html <http://cr.openjdk.java.net/~mseledtsov/8181592.00/test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest.html>
Could you please explain why oraclelinux 7.0 is used as a base image for test. 

http://cr.openjdk.java.net/~mseledtsov/8181592.00/test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java.html <http://cr.openjdk.java.net/~mseledtsov/8181592.00/test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java.html>
The content looks fine.

I don’t see anything to clean up docker images on the system. Could you please explain how tests are going to cleanup images.


> On Sep 21, 2017, at 5:58 PM, mikhailo <mikhailo.seledtsov at oracle.com> wrote:
> Please review this initial drop of Docker test utils and a sanity test. This change lays ground
> for further test development and test utils improvement in this area.
>     JBS: https://bugs.openjdk.java.net/browse/JDK-8181592
>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8181592.00/
>     Testing:
>        - run this test on machine with Docker enabled - works
>        - run this test on Linux-x64 with no Docker engine or Docker disabled - test skipped (as expected)
>        - run this test on automated system - in progress
> Thank you,
> Misha

More information about the hotspot-runtime-dev mailing list