RFR(xs): 8202073: MetaspaceAllocationTest gtest shall lock during space creation
axel.siebenborn at sap.com
Mon Apr 23 15:27:26 UTC 2018
Is it really necessary, that the metadata_lock is acquired for the initialization of ClassLoaderMetaspace?
For all current uses of the ClassLoaderMetaspace constructor the lock is hold anyway.
But the Constructor could be used somewhere else and in that case, I would not want the assertion in add_chunk.
But I'm not that in the code, maybe I'm missing something.
Besides that, the change looks good.
However, I'm not a reviewer.
> -----Original Message-----
> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
> bounces at openjdk.java.net] On Behalf Of Thomas Stüfe
> Sent: Samstag, 21. April 2018 07:36
> To: Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>
> Subject: Re: RFR(xs): 8202073: MetaspaceAllocationTest gtest shall lock
> during space creation
> Hi all,
> may I have a second reviewer please.
> new webrev (I missed an include and broke the non-pch builds):
> Thanks, Thomas
> On Fri, Apr 20, 2018 at 9:11 AM, Thomas Stüfe <thomas.stuefe at gmail.com>
> > May I please have reviews for this small fix to the
> > metaspace-allocate-stresstest-gtest:
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8202073
> > webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8202073-
> > MetaspaceAllocationTest mimicks ClassLoaderMetaspace creation,
> > allocation and destruction to stress metaspace allocation.
> > So it runs outside the normal create-allocate-delete cycle in the VM.
> > For instance, there are no associated ClassLoaderData. So, the test
> > needs to mimick the surroundings of the VM.
> > This means, when creating ClassLoaderMetaspace objects, the test needs
> > to lock its associated lock. In the VM, this happens in
> > ClassLoaderData::metaspace_non_null(), and there the associated lock
> > is pulled before allocation too.
> > Thanks, Thomas
More information about the hotspot-runtime-dev