RFR 8197960: [TESTBUG] remove/modify runtime tests which use java ee or corba modules
harold.seigel at oracle.com
Wed Apr 25 18:30:16 UTC 2018
Thanks for the review!
I'll probably leave the lines as is, but thanks for the suggestion.
On 4/25/2018 1:34 PM, Calvin Cheung wrote:
> Hi Harold,
> The change looks good. Just a minor comment:
> 72 oa.shouldContain("I pass!");
> 73 oa.shouldHaveExitValue(0);
> the above can be simplified to:
> oa.shouldContain("I pass!")
> Similar simplification could be done to lines 107-108.
> I don't need to see another webrev if you decide to make the above
> On 4/25/18, 5:16 AM, harold seigel wrote:
>> Please review this fix for hotspot runtime test
>> PatchModuleClassList.java. The test needed to be fixed because of
>> the removal of the Java EE and CORBA modules.
>> Open Webrev:
>> JBS Task: https://bugs.openjdk.java.net/browse/JDK-8197960
>> The fixed test was tested on Linux, Windows, Solaris, and Mac OSX.
>> Thanks, Harold
More information about the hotspot-runtime-dev