RFR (S) 8208677: Move inner metaspace cleaning out of class unloading

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Wed Aug 8 20:36:30 UTC 2018

Hi Serguei,  Thank you for the code review.  I thought you were going on 
vacation so I pushed it already.

I will add a comment next time I change classLoaderData, which is 
probably soon.

Thank you!

On 8/8/18 4:15 PM, serguei.spitsyn at oracle.com wrote:
> Hi Coleen,
> It looks good to me.
> Thank you a lot for taking care about this!
> This refactoring is tricky so it is worth to add a comment, for instance,
> to explain the conditions/logic that trigger metaspaces cleaning.
> It can be added to the should_clean_metaspaces or do_cleanup_tasks 
> where it is used.
> Thanks,
> Serguei
> On 8/6/18 11:47, coleen.phillimore at oracle.com wrote:
>> Summary: move to safepoint cleanup actions to do if needed.
>> This is in support of concurrent class unloading.   See bug 
>> description for more details.
>> open webrev at http://cr.openjdk.java.net/~coleenp/8208677.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8208677
>> Ran mach5 hs-tier1-5, with no failures on Friday.  hs-tier1,2 with 
>> expected failures today.
>> The test/hotspot/jtreg/runtime/RedefineRunningMethods.java and 
>> RedefineLeak.java test this code.  Fixed and verified with logging in 
>> the first test.
>> thanks,
>> Coleen

More information about the hotspot-runtime-dev mailing list