RFR  8207838: AArch64: Float registers incorrectly resture in JNI call
aph at redhat.com
Tue Aug 14 18:03:07 UTC 2018
On 08/14/2018 05:42 PM, Andrew Haley wrote:
> On 08/14/2018 05:07 PM, Andrew Dinn wrote:
>> That answers Aleksey's question as to why use all those threads.
>> However, it does not address (what I think is) his point that the test
>> may give false positives because exceptions will not happen in the main
>> thread and hence not derail the test.
>> An ExecutorService is the Rolls-Royce option. A simpler solution is to
>> set a static flag before starting the threads then if any of them enters
>> the block where the throw happens have it clear the flag. The test can
>> assert on the flag being set after all the joins complete (finesse is
>> all very well, Aleksey, but brute force is so cheap and easy ;-).
> I get that, but with plenty of threads all of them are likely to be
> blocked at some point. However, I'll have a look at changing the test.
Your suggestion works fine, but the test runs very slowly. Tomorrow I'll
submit a new version of the test which fails more quickly.
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the hotspot-runtime-dev