RFR(S) 8206115 - Use shared macros for JavaClasses::compute_offsets and MetaspaceShared::serialize_well_known_classes
ioi.lam at oracle.com
Wed Aug 15 21:36:30 UTC 2018
Thanks Coleen. As a follow on, I’ll use more macros to clean up the boilerplate code in javaClasses.cpp
> On Aug 15, 2018, at 12:44 PM, coleen.phillimore at oracle.com wrote:
> I think this change looks really good. There's probably opportunity to use the X macro in more creative ways but this seems good for now.
>> On 8/15/18 12:37 AM, Ioi Lam wrote:
>> As I noted in the comments on this RFE, we already have a bug where
>> java_lang_Integer_IntegerCache was missing from
>> To avoid such problems in the future, I added a new macro in javaClasses.hpp,
>> BASIC_JAVA_CLASSES_DO, which is used by JavaClasses::compute_offsets and
>> For clean up, I also renamed all the <Class>::serialize() functions to
>> <Class>::serialize_offsets() to reflect what these functions really do.
>> The old MetaspaceShared::serialize_well_known_classes function is now
>> Testing with hs tiers 1/2.
>> - Ioi
More information about the hotspot-runtime-dev