RFR[S] 8209657 Refactor filemap.hpp to simplify integration with Serviceability Agent
jini.george at oracle.com
Tue Aug 21 05:31:38 UTC 2018
It looks good to me except for:
313 assert(i >= 0 && i <= NUM_CDS_REGIONS, "invalid region");
Shouldn't the assert be:
assert(i >= 0 && i < NUM_CDS_REGIONS, "invalid region");
On 8/21/2018 1:53 AM, Ioi Lam wrote:
> I've updated the webrev to merge with Calvin's change in the latest repo.
> - Ioi
> On 8/17/2018 2:22 PM, Ioi Lam wrote:
>> [Resending to include bug number in e-mail subject line]
>> The CDS FileMapHeader type was big, and was duplicated 4 times in our
>> I moved the parts that's common to HotSpot and Serviceability Agent
>> into a new
>> common header file, cds.h.
>> I also did various clean up in filemap.cpp/hpp:
>> - avoid using unwieldy nested types such as
>> - added convenience function space_at(), so you have
>> struct FileMapInfo::FileMapHeader::space_info* si =
>> CDSFileMapRegion* si = space_at(i);
>> hs tiers 1,2,3 on all supported platforms.
More information about the hotspot-runtime-dev