8209150: [TESTBUG] Add logging to verify JDK-8197901 to a different test
leonid.mesnik at oracle.com
Tue Aug 21 21:25:07 UTC 2018
Thank you for review and feedback.
> On Aug 21, 2018, at 2:01 PM, coleen.phillimore at oracle.com wrote:
> Thank you, this is better!
> 34 * @run main/othervm -Xmx256m -XX:MaxMetaspaceSize=64m -javaagent:redefineagent.jar -Xlog:all=trace:file=all.log RedefineClasses
> From this logging, did you verify that the output goes to all.log? I think the logging should be -Xlog:all=trace:all.log otherwise in the other test, I noticed it goes to the jtr file.
Yes, logging is done in al.log file and not in the jar file.
> Also, the copyright should only be 2018.
I copied source code from other test and left comment about this. I think that it should be the first year of original piece of source code. So left 2014 as a first year.
> On 8/21/18 4:53 PM, Leonid Mesnik wrote:
>> Could you please review regression test for 8197901.
>> I verified that test reproduce crash from JDK-8197901 <https://bugs.openjdk.java.net/browse/JDK-8197901> if fix is not applied. Also this test is regression test for bug JDK-8209758 <https://bugs.openjdk.java.net/browse/JDK-8209758> which I found using it.
>> I was unable to create simpler version which reproduce bug 8197901 since there is no good way to control when Klass:external_name is invoked while java_mirror is not correct.
>> webrev: http://cr.openjdk.java.net/~lmesnik/8209150/webrev.00/ <http://cr.openjdk.java.net/~lmesnik/8209150/webrev.00/>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8209150 <https://bugs.openjdk.java.net/browse/JDK-8209150>
More information about the hotspot-runtime-dev