RFR(S) 8193664  - AppCDS tests should use -XX:+UnlockCommercialFeatures when running with commercial JDK
david.holmes at oracle.com
Thu Jan 11 06:04:43 UTC 2018
On 11/01/2018 2:42 PM, Ioi Lam wrote:
> Hi David,
> Thanks for the review. I've removed the duplicated code and added a new
> method TestCommon.makeCommandLineForAppCDS. The code looks like this now:
> ! ProcessBuilder dumpPb = ProcessTools.createJavaProcessBuilder(true,
> ! TestCommon.makeCommandLineForAppCDS(
> "-cp", appJar,
> "-XX:SharedArchiveConfigFile=" + sharedArchiveConfigFile,
> ! "-Xlog:cds,cds+hashtables"));
Looks good! Thanks for that.
public static String makeCommandLineForAppCDS(String... args) throws
why the throws clause?
> Updated webrev is at
> I also updated the copyright years as mentioned by Jiangli.
> - Ioi
> On 1/10/18 2:31 PM, David Holmes wrote:
>> Hi Ioi,
>> I have two small reservations ...
>> 1. The duplicate definitions of commercial()
>> 2. The use of -showversion in the openJDK case. Might not this
>> interfere with output parsing?
>> On 11/01/2018 5:47 AM, Ioi Lam wrote:
>>> Please review this small change in the AppCDS tests
>>> * This patch changes tests ONLY. There's no code change.
>>> * The change affects ONLY the commercial JDK built by Oracle.
>>> * It does not affect the OpenJDK
>>> * Oracle commercial JDK 10 still requires
>>> to be specified when using AppCDS tests. This requirement will be
>>> removed soon in the future, but meanwhile, we need to add a few
>>> -XX:+UnlockCommercialFeatures flags in the test cases to make
>>> them pass.
>>> Tested under both Oracle commercial JDK and OpenJDK builds. All affected
>>> tests passed in both configurations.
>>> - Ioi
More information about the hotspot-runtime-dev